~james/core

core/spindle/mill/executor/observe_test.go -rw-r--r-- 2.6 KiB
452f17b7 — james chore(import): snapshot james.dad.town/core at f70c71c7696a 14 hours ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
package executor

import (
	"context"
	"encoding/base64"
	"io"
	"log/slog"
	"strings"
	"testing"

	"github.com/bluesky-social/indigo/atproto/syntax"

	"tangled.org/core/notifier"
	"tangled.org/core/spindle/config"
	millv1 "tangled.org/core/spindle/mill/proto/gen"
	"tangled.org/core/spindle/models"
	"tangled.org/core/spindle/secrets"
	"tangled.org/core/workflow"
)

const maskedToken = "eyJhbGciOiJFUzI1NiJ9.eyJzdWIiOiJkaWQ6cGxjOnJlcG8ifQ.c2ln"

// the live frames the mill serves unauthenticated must hide everything the
// persisted log hides, encoded variants included
func TestLiveStreamMasksEncodedCredentials(t *testing.T) {
	d := testDB(t)
	n := notifier.New()
	enc := newCaptureEncoder()
	e := &Executor{
		cfg:            &config.Config{Server: config.Server{LogDir: t.TempDir()}},
		db:             d,
		n:              &n,
		l:              slog.New(slog.NewTextHandler(io.Discard, nil)),
		active:         make(map[string]*reservation),
		maxOutboxBytes: 10 * 1024 * 1024,
		enc:            enc,
	}
	if err := e.initOutbox(); err != nil {
		t.Fatal(err)
	}
	e.lifecycleCtx = context.Background()

	inner := &fakeEngine{secrets: make(chan []secrets.UnlockedSecret, 1), done: make(chan struct{})}
	slot := &fakeSlot{}
	repoDid, err := syntax.ParseDID("did:web:example.com")
	if err != nil {
		t.Fatal(err)
	}
	repoDidString := repoDid.String()
	res := &reservation{
		leaseID:    "lease-1",
		wid:        models.WorkflowId{PipelineId: models.PipelineId("r"), Name: "build"},
		realEngine: inner,
		slot:       slot,
		wf:         &models.Workflow{Name: "build", Steps: []models.Step{fakeStep{}}},
		pipeline: &models.Pipeline{
			RepoDid: repoDid,
			TriggerMetadata: &workflow.TriggerMetadata{
				Repo: &workflow.TriggerRepo{RepoDid: &repoDidString},
			},
			TrustedSource: true,
		},
	}
	e.active[res.leaseID] = res

	e.handleCommit(context.Background(), &millv1.CommitLease{
		LeaseId: res.leaseID,
		Secrets: []*millv1.Secret{{Key: models.IDTokenEnvVar, Value: maskedToken}},
	})

	encoded := base64.StdEncoding.EncodeToString([]byte(maskedToken))
	for name, line := range map[string]string{
		"raw":      models.IDTokenEnvVar + "=" + maskedToken,
		"base64":   "echo $" + models.IDTokenEnvVar + " | base64: " + encoded,
		"unpadded": "no-pad: " + strings.TrimRight(encoded, "="),
	} {
		masked := e.maskSecrets(res, line)
		if strings.Contains(masked, maskedToken) || strings.Contains(masked, encoded) {
			t.Fatalf("%s line reached the live stream: %q", name, masked)
		}
		if !strings.Contains(masked, "***") {
			t.Fatalf("%s line was not masked at all: %q", name, masked)
		}
	}

	if res.stopTail != nil {
		res.stopTail()
	}
	e.jobsWG.Wait()
}