~james/core

core/spindle/mill/restore_test.go -rw-r--r-- 15.1 KiB
452f17b7 — james chore(import): snapshot james.dad.town/core at f70c71c7696a 16 hours ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
package mill

import (
	"context"
	"path/filepath"
	"testing"
	"time"

	"tangled.org/core/notifier"
	"tangled.org/core/spindle/db"
	millproto "tangled.org/core/spindle/mill/proto"
	millv1 "tangled.org/core/spindle/mill/proto/gen"
	"tangled.org/core/spindle/models"
	"tangled.org/core/spindle/observability"
)

func restoreTestMill(t *testing.T, cfg Config) (*Mill, *db.DB) {
	t.Helper()
	bdb, err := db.Make(context.Background(), filepath.Join(t.TempDir(), "mill.db"))
	if err != nil {
		t.Fatalf("db.Make: %v", err)
	}
	t.Cleanup(func() { bdb.Close() })
	n := notifier.New()
	m := New(discardLogger(), cfg)
	m.Attach(bdb, &n, testQuotaManager(t, bdb))
	return m, bdb
}

func restoredMill(t *testing.T, bdb *db.DB, cfg Config) *Mill {
	t.Helper()
	n := notifier.New()
	m := New(discardLogger(), cfg)
	m.Attach(bdb, &n, testQuotaManager(t, bdb))
	if err := m.RestoreState(); err != nil {
		t.Fatalf("RestoreState: %v", err)
	}
	return m
}

func TestRestoreStateRebuildsLeasesAndCursors(t *testing.T) {
	_, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})

	if err := bdb.SaveMillLease(db.MillLease{
		LeaseID: "lease-1", NodeID: "node-1", Epoch: "inc-1", Engine: "dummy",
		PipelineID: "rkey1", Workflow: "build", State: leaseRowRunning,
	}); err != nil {
		t.Fatalf("SaveMillLease: %v", err)
	}
	if err := bdb.ApplyEventBatch(nil, func(tx *db.EventBatchTx) error { return tx.AdvanceCursor("node-1", "inc-1", 7) }); err != nil {
		t.Fatalf("AdvanceCursor: %v", err)
	}

	m2 := restoredMill(t, bdb, Config{ReconnectGrace: time.Minute})

	m2.mu.Lock()
	lease := m2.leases["lease-1"]
	seqno := m2.nodeSeqno["node-1/inc-1"]
	m2.mu.Unlock()

	if lease == nil {
		t.Fatal("restored mill has no lease-1")
	}
	if !lease.orphaned {
		t.Fatal("restored lease is not orphaned; a terminal would be delivered to a waiter that does not exist")
	}
	if lease.getState() != leaseRunning {
		t.Fatalf("restored lease state = %v, want leaseRunning", lease.getState())
	}
	wantWid := models.WorkflowId{PipelineId: models.PipelineId("rkey1"), Name: "build"}
	if lease.wid != wantWid {
		t.Fatalf("restored lease wid = %+v, want %+v", lease.wid, wantWid)
	}
	if seqno != 7 {
		t.Fatalf("restored cursor = %d, want 7", seqno)
	}
}

func TestOrphanTerminalAuthorsStatusRow(t *testing.T) {
	_, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	if err := bdb.SaveMillLease(db.MillLease{
		LeaseID: "lease-1", NodeID: "node-1", Epoch: "inc-1", Engine: "dummy",
		PipelineID: "rkey1", Workflow: "build", State: leaseRowRunning,
	}); err != nil {
		t.Fatalf("SaveMillLease: %v", err)
	}
	if err := bdb.ApplyEventBatch(nil, func(tx *db.EventBatchTx) error { return tx.AdvanceCursor("node-1", "inc-1", 3) }); err != nil {
		t.Fatalf("AdvanceCursor: %v", err)
	}

	m := restoredMill(t, bdb, Config{ReconnectGrace: time.Minute})

	sess := newSession("node-1", "inc-1", nil, nopEncoder(), discardLogger())
	resume, ok := m.attachSession(sess)
	if !ok {
		t.Fatal("attachSession rejected the reconnecting executor")
	}
	if resume != 3 {
		t.Fatalf("attachSession resume seqno = %d, want restored cursor 3", resume)
	}

	_ = m.onEventBatch(sess, &millv1.EventBatch{
		Epoch: sess.epoch,
		Events: []*millv1.Event{
			{
				Seqno:   4,
				LeaseId: "lease-1",
				Payload: &millv1.Event_AttemptResult{
					AttemptResult: &millv1.AttemptResult{
						Status: millv1.TerminalStatus_TERMINAL_STATUS_SUCCESS,
					},
				},
			},
		},
	})

	wid := models.WorkflowId{PipelineId: models.PipelineId("rkey1"), Name: "build"}
	st, err := bdb.GetStatus(wid)
	if err != nil {
		t.Fatalf("GetStatus after orphan terminal: %v", err)
	}
	if st != models.StatusKindSuccess {
		t.Fatalf("orphan terminal authored status %q, want success", st)
	}

	m.mu.Lock()
	_, still := m.leases["lease-1"]
	m.mu.Unlock()
	if still {
		t.Fatal("finished orphan still in the lease map")
	}
	if rows, _ := bdb.ListMillLeases(); len(rows) != 0 {
		t.Fatalf("finished orphan still persisted: %+v", rows)
	}
}

func TestSnapshotReconciliationFailsDroppedOrphans(t *testing.T) {
	_, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	for _, l := range []db.MillLease{
		{LeaseID: "lease-kept", NodeID: "node-1", Epoch: "inc-1", Engine: "dummy", PipelineID: "r1", Workflow: "w", State: leaseRowRunning},
		{LeaseID: "lease-gone", NodeID: "node-1", Epoch: "inc-1", Engine: "dummy", PipelineID: "r2", Workflow: "w", State: leaseRowRunning},
	} {
		if err := bdb.SaveMillLease(l); err != nil {
			t.Fatalf("SaveMillLease(%s): %v", l.LeaseID, err)
		}
	}

	m := restoredMill(t, bdb, Config{ReconnectGrace: time.Minute})

	sess := newSession("node-1", "inc-1", nil, nopEncoder(), discardLogger())
	m.attachSession(sess)

	m.onSnapshot(sess, &millv1.NodeSnapshot{
		Seqno:          1,
		ActiveLeaseIds: []string{"lease-kept"},
	})

	m.mu.Lock()
	_, kept := m.leases["lease-kept"]
	_, gone := m.leases["lease-gone"]
	m.mu.Unlock()
	if !kept {
		t.Fatal("reconciliation dropped a lease the executor still holds")
	}
	if gone {
		t.Fatal("reconciliation kept a lease the executor no longer holds")
	}

	st, err := bdb.GetStatus(models.WorkflowId{PipelineId: models.PipelineId("r2"), Name: "w"})
	if err != nil {
		t.Fatalf("GetStatus for dropped orphan: %v", err)
	}
	if st != models.StatusKindFailed {
		t.Fatalf("dropped orphan authored status %q, want failed", st)
	}
}
func TestSnapshotReconciliationPreservesRequestedCancellation(t *testing.T) {
	m, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	lease := newLease("lease-1", "node-1", "inc-old", "dummy")
	lease.wid = models.WorkflowId{
		PipelineId: models.PipelineId("r1"),
		Name:       "w",
	}
	lease.setState(leaseRunning)
	lease.requestCancel("workflow destroyed")
	if err := m.persistLease(lease, leaseRowRunning); err != nil {
		t.Fatalf("persistLease: %v", err)
	}
	m.mu.Lock()
	m.leases[lease.id] = lease
	m.mu.Unlock()

	sess := newSession("node-1", "inc-new", nil, nopEncoder(), discardLogger())
	m.attachSession(sess)
	if err := m.onSnapshot(sess, &millv1.NodeSnapshot{Seqno: 1}); err != nil {
		t.Fatalf("onSnapshot: %v", err)
	}

	st, err := bdb.GetStatus(lease.wid)
	if err != nil {
		t.Fatalf("GetStatus: %v", err)
	}
	if st != models.StatusKindCancelled {
		t.Fatalf("reconciled status = %q, want cancelled", st)
	}
}

func TestSnapshotReconciliationCancelsUnknownExecutorLease(t *testing.T) {
	m, _ := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	cancelled := make(chan string, 1)
	sess := newSession("node-1", "inc-1", nil, scriptedEncoder(func(msg *millproto.Message) error {
		if cancel := msg.GetCancelAttempt(); cancel != nil {
			cancelled <- cancel.GetLeaseId()
		}
		return nil
	}), discardLogger())
	m.attachSession(sess)

	if err := m.onSnapshot(sess, &millv1.NodeSnapshot{
		Seqno:          1,
		ActiveLeaseIds: []string{"executor-only"},
		Engines: map[string]*millv1.EngineAvailability{
			"dummy": {Available: true},
		},
	}); err != nil {
		t.Fatalf("onSnapshot: %v", err)
	}
	select {
	case id := <-cancelled:
		if id != "executor-only" {
			t.Fatalf("cancelled lease = %q, want executor-only", id)
		}
	default:
		t.Fatal("snapshot reconciliation left an executor-only lease running")
	}
	assertRankedNodes(t, m.rankCandidates("dummy", nil, false), nil)
	if err := m.onEventBatch(sess, &millv1.EventBatch{
		Epoch: sess.epoch,
		Events: []*millv1.Event{{
			Seqno:   1,
			LeaseId: "executor-only",
			Payload: &millv1.Event_AttemptResult{AttemptResult: &millv1.AttemptResult{
				Status: millv1.TerminalStatus_TERMINAL_STATUS_CANCELLED,
			}},
		}},
	}); err != nil {
		t.Fatalf("onEventBatch: %v", err)
	}
	assertRankedNodes(t, m.rankCandidates("dummy", nil, false), []string{"node-1"})
}

func TestSweepFailsOrphansOfAbsentExecutors(t *testing.T) {
	_, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	if err := bdb.SaveMillLease(db.MillLease{
		LeaseID: "lease-1", NodeID: "node-absent", Epoch: "inc-absent", Engine: "dummy",
		PipelineID: "r1", Workflow: "w", State: leaseRowReserved,
	}); err != nil {
		t.Fatalf("SaveMillLease: %v", err)
	}

	m := restoredMill(t, bdb, Config{ReconnectGrace: time.Minute})
	m.sweepUnclaimedOrphans()

	m.mu.Lock()
	_, still := m.leases["lease-1"]
	m.mu.Unlock()
	if still {
		t.Fatal("sweep kept an orphan whose executor never reconnected")
	}
	st, err := bdb.GetStatus(models.WorkflowId{PipelineId: models.PipelineId("r1"), Name: "w"})
	if err != nil {
		t.Fatalf("GetStatus after sweep: %v", err)
	}
	if st != models.StatusKindFailed {
		t.Fatalf("sweep authored status %q, want failed", st)
	}
	if rows, _ := bdb.ListMillLeases(); len(rows) != 0 {
		t.Fatalf("swept orphan still persisted: %+v", rows)
	}
}

func TestAckSeqnoPersistsCursor(t *testing.T) {
	m, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	sess := newSession("node-1", "inc-1", nil, nopEncoder(), discardLogger())
	m.attachSession(sess)

	owned := newLease("lease-1", "node-1", "inc-1", "dummy")
	owned.wid = models.WorkflowId{PipelineId: models.PipelineId("r"), Name: "build"}
	m.mu.Lock()
	m.leases[owned.id] = owned
	m.mu.Unlock()

	err := m.onEventBatch(sess, &millv1.EventBatch{
		Epoch: sess.epoch,
		Events: []*millv1.Event{
			{
				Seqno:   1,
				LeaseId: owned.id,
				Payload: &millv1.Event_StatusEvent{
					StatusEvent: &millv1.StatusEvent{
						Status: millv1.NonterminalStatus_NONTERMINAL_STATUS_RUNNING,
					},
				},
			},
		},
	})
	if err != nil {
		t.Fatalf("onEventBatch: %v", err)
	}

	cursors, err := bdb.ListExecutorCursors()
	if err != nil {
		t.Fatalf("ListExecutorCursors: %v", err)
	}
	if len(cursors) != 1 || cursors[0].AckedSeqno != 1 {
		t.Fatalf("persisted cursor = %+v, want seqno 1", cursors)
	}
}

func TestOrphanTerminalFailureKeepsLeaseAndSeqnoRetryable(t *testing.T) {
	_, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	if err := bdb.SaveMillLease(db.MillLease{
		LeaseID: "lease-1", NodeID: "node-1", Epoch: "inc-1", Engine: "dummy",
		PipelineID: "rkey1", Workflow: "build", State: leaseRowRunning,
	}); err != nil {
		t.Fatalf("SaveMillLease: %v", err)
	}
	if err := bdb.ApplyEventBatch(nil, func(tx *db.EventBatchTx) error { return tx.AdvanceCursor("node-1", "inc-1", 3) }); err != nil {
		t.Fatalf("AdvanceCursor: %v", err)
	}
	if _, err := bdb.Exec(`
		create trigger reject_orphan_lease_delete
		before delete on mill_leases
		begin
			select raise(abort, 'forced delete failure');
		end
	`); err != nil {
		t.Fatalf("create failure trigger: %v", err)
	}

	m := restoredMill(t, bdb, Config{ReconnectGrace: time.Minute})
	sess := newSession("node-1", "inc-1", nil, nopEncoder(), discardLogger())
	if _, ok := m.attachSession(sess); !ok {
		t.Fatal("attachSession rejected reconnect")
	}
	batch := &millv1.EventBatch{
		Epoch: sess.epoch,
		Events: []*millv1.Event{
			{
				Seqno:   4,
				LeaseId: "lease-1",
				Payload: &millv1.Event_AttemptResult{
					AttemptResult: &millv1.AttemptResult{
						Status: millv1.TerminalStatus_TERMINAL_STATUS_SUCCESS,
					},
				},
			},
		},
	}
	if err := m.onEventBatch(sess, batch); err == nil {
		t.Fatal("orphan terminal stream succeeded despite forced transaction failure")
	}

	m.mu.Lock()
	lease := m.leases["lease-1"]
	seqno := m.nodeSeqno["node-1/inc-1"]
	m.mu.Unlock()
	if lease == nil || lease.getState() == leaseDone {
		t.Fatal("failed orphan completion made the in-memory lease unretryable")
	}
	if seqno != 3 {
		t.Fatalf("in-memory stream seqno = %d, want 3", seqno)
	}
	if rows, err := bdb.ListMillLeases(); err != nil || len(rows) != 1 {
		t.Fatalf("durable leases after transaction rollback = %+v, err = %v; want retained lease", rows, err)
	}
	var statuses int
	if err := bdb.QueryRow(`select count(*) from workflow_statuses`).Scan(&statuses); err != nil {
		t.Fatalf("count workflow statuses: %v", err)
	}
	if statuses != 0 {
		t.Fatalf("terminal statuses after transaction rollback = %d, want 0", statuses)
	}

	if _, err := bdb.Exec(`drop trigger reject_orphan_lease_delete`); err != nil {
		t.Fatalf("drop failure trigger: %v", err)
	}
	if err := m.onEventBatch(sess, batch); err != nil {
		t.Fatalf("retry orphan terminal: %v", err)
	}
	m.mu.Lock()
	_, still := m.leases["lease-1"]
	seqno = m.nodeSeqno["node-1/inc-1"]
	m.mu.Unlock()
	if still {
		t.Fatal("successful orphan completion retained in-memory lease")
	}
	if seqno != 4 {
		t.Fatalf("in-memory stream seqno after retry = %d, want 4", seqno)
	}
	if rows, err := bdb.ListMillLeases(); err != nil || len(rows) != 0 {
		t.Fatalf("durable leases after successful retry = %+v, err = %v; want none", rows, err)
	}
}

func TestSyntheticTerminalRespectsPersistedMetricAuthority(t *testing.T) {
	m, _ := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	metrics := observability.NewMetrics()
	m.RegisterMetrics(metrics)

	lease := newLease("lease-local-metrics", "node-old", "epoch-old", "dummy")
	lease.wid = models.WorkflowId{
		PipelineId: models.PipelineId("pipeline"),
		Name:       "build",
	}
	lease.millRecordsTerminalMetrics = false
	if err := m.persistLease(lease, leaseRowRunning); err != nil {
		t.Fatal(err)
	}
	m.mu.Lock()
	m.leases[lease.id] = lease
	m.mu.Unlock()

	reason := "executor lost"
	if err := m.finishOrphan(lease, string(models.StatusKindFailed), &reason, nil); err != nil {
		t.Fatal(err)
	}
	families, err := metrics.Registry().Gather()
	if err != nil {
		t.Fatal(err)
	}
	for _, family := range families {
		if family.GetName() == "spindle_workflows_total" {
			t.Fatal("mill synthesized a terminal while the executor retained metric authority")
		}
	}
}

func TestSweepKeepsOutcomeOfUnclaimedOrphan(t *testing.T) {
	_, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute})
	wid := models.WorkflowId{PipelineId: models.PipelineId("r1"), Name: "w"}
	if err := bdb.SaveMillLease(db.MillLease{
		LeaseID: "lease-1", NodeID: "node-absent", Epoch: "inc-absent", Engine: "dummy",
		PipelineID: "r1", Workflow: "w", State: leaseRowRunning,
	}); err != nil {
		t.Fatalf("SaveMillLease: %v", err)
	}
	n := notifier.New()
	if err := bdb.StatusSuccess(wid, &n); err != nil {
		t.Fatal(err)
	}

	m := restoredMill(t, bdb, Config{ReconnectGrace: time.Minute})
	m.sweepUnclaimedOrphans()

	if st, err := bdb.GetStatus(wid); err != nil || st != models.StatusKindSuccess {
		t.Fatalf("status after sweep = %q (err %v), want success", st, err)
	}
	if rows, _ := bdb.ListMillLeases(); len(rows) != 0 {
		t.Fatalf("swept orphan still persisted: %+v", rows)
	}
}

func TestCancelTeardownDeadlineKeepsRecordedOutcome(t *testing.T) {
	m, bdb := restoreTestMill(t, Config{ReconnectGrace: time.Minute, CancelTeardownTimeout: time.Second})
	lease := newLease("lease-1", "node-1", "inc-1", "dummy")
	lease.wid = models.WorkflowId{PipelineId: models.PipelineId("r1"), Name: "w"}
	lease.setState(leaseRunning)
	if err := m.persistLease(lease, leaseRowRunning); err != nil {
		t.Fatalf("persistLease: %v", err)
	}
	m.mu.Lock()
	m.leases[lease.id] = lease
	m.mu.Unlock()
	n := notifier.New()
	if err := bdb.StatusSuccess(lease.wid, &n); err != nil {
		t.Fatal(err)
	}

	// a repo wipe cancels a finished workflow whose debug shell still holds the vm
	lease.requestCancel("repo wiped")
	m.checkCancelTeardown(lease)

	select {
	case res := <-lease.terminal:
		if res.Status != millv1.TerminalStatus_TERMINAL_STATUS_SUCCESS {
			t.Fatalf("RunStep got %v, want success", res.Status)
		}
	default:
		t.Fatal("no terminal delivered to RunStep")
	}
	if st, err := bdb.GetStatus(lease.wid); err != nil || st != models.StatusKindSuccess {
		t.Fatalf("status = %q (err %v), want success", st, err)
	}
}